Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R cmd check notes #55

Merged
merged 4 commits into from
Oct 30, 2023
Merged

R cmd check notes #55

merged 4 commits into from
Oct 30, 2023

Conversation

certara-jcraig
Copy link
Collaborator

@certara-jcraig certara-jcraig commented Oct 25, 2023

To resolve R CMD check notes and update details for 1.5.0 release.

Note, due to data.table parallelization, CRAN NOTES created on debian around CPU exceeding ratio (CRAN sets at 2.5) times elapsed time:

Flavor: r-devel-linux-x86_64-debian-gcc
Check: tests, Result: NOTE
    Running 'testthat.R' [47s/8s]
  Running R code in 'testthat.R' had CPU time 6.3 times elapsed time

Flavor: r-devel-linux-x86_64-debian-gcc
Check: re-building of vignette outputs, Result: NOTE
  Re-building vignettes had CPU time 4.6 times elapsed time

Discussion here: Rdatatable/data.table#5658

As a resolution, number of threads has been restricted to 2 in vignettes and tests via data.table::setDTthreads(2). Noting that usage of env variable OMP_THREAD_LIMIT e.g., Sys.setenv("OMP_THREAD_LIMIT" = 2) did not work.

to resolve R CMD check notes when working with unquoted varnames in data.table and ggplot2
@codecov-commenter
Copy link

Codecov Report

Merging #55 (b6d4541) into master (7d18e37) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b6d4541 differs from pull request most recent head 2d88c91. Consider uploading reports for the commit 2d88c91 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files           4        4           
  Lines        1097     1097           
=======================================
  Hits          912      912           
  Misses        185      185           
Files Coverage Δ
R/binless.R 89.25% <100.00%> (ø)
R/vpcstats.R 77.17% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

to skip computationally intensive tests and limit DT threads in vignette and testthat
@certara-jcraig certara-jcraig merged commit 2c5b6fc into master Oct 30, 2023
4 checks passed
@certara-jcraig certara-jcraig deleted the r_cmd_check_notes branch October 30, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants