Deprecate usage of ComparableX509 in encoding and decoding functions
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohemorange
force-pushed
the
encode-decode
branch
4 times, most recently
from
f74c30b to
d304042
Compare
ohemorange
force-pushed
the
encode-decode
branch
from
d304042 to
1c2de2e
Compare
Closed
ohemorange
requested review from
a team and
bmw
and removed request for
a team and
bmw
|
Sorry wrong PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely based on #202.
Marks
json_util.decode_certandjson_util.decode_csras deprecated, and createsjson_util.decode_cert_cryptographyandjson_util.decode_csr_cryptographyin their place.Deprecates accepting
ComparableX509injson_util.encode_certandjson_util.encode_csr, and accepts the relevantcryptography.x509objects in their place (either is accepted as input for now).