Dev #32
Merged
Dev #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix minor issue
This removes the burden of rendering the dialog each time a post is rendered
I am fed up seeing these animations bloat my profiling view, hope it improve things
This will be necessary as we implement relay feeds
The value was being set to zero when changing feeds
It doesn't work due index constraints, the created_at field is not respected
That wasn't working when using the app without IndexedDB
As we are using NIP-10 replies to a lot of crap, this fixes the issue.
This was a bad idea, and clogs everything up on indexeddb side, impacting all the relevant info to load like notes on feed and other stuff. This makes everything way faster
No need to decode everytime to check if the nevent is actually a note1 Also fixes underline link style when it's on deck
Fixed AppBar position sticky, it's causing too much flickering on ios
There's no need to render a bottom sheet for images on mobile
This optimizes a lot of stuff related to tooltips and popovers, by just simply not rendering anything at all, only on mouse enter This was likely the root of all evil
Although virtua is great and really well done, it was caused too many issues, at the end, we never needed virtualized lists to begin with. Things are not are way smoother especially on mobile
This will be default for relay feeds
Now with ContentProvider context is much easier and lightweight toStream pass common props like `dense`, `disableLink` and other stuff, things are way more lightweight now
Limited based pagination way better for almost every situation, but doesn't work well with outbox at home feed, so we will use limit pagination for profile and notification for now.
This unifies comment and note model which had loads of duplicated logic, now the note store isn't really global, we had a lot of issues of opening replies for one note affecting that same note but in different column of the deck (or the same feed), now note state are much more local easy to deal with it.
Looks nice on mobile
Now replies of selected replies are properly rendered
Now clicking on reply links from a NEventModule context will replace the current deck column, instead of adding a new one, which makes sense for reply threads as users are just trying to see more nested replies
We can't relay on bunkerUrl pubkey as the actual pubkey
Only for relay feeds for now
Make things easier to find
Add relay feeds, tags and media columns deck
So we can share on relay page
Only remote bunker for now
We still need a better limit based pagination strategy, I thought a basic approach would work just fine but no, any old cached note will make a huge gap on the feed.
better than nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.