Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sw/fix ace nonorthog #13

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Sw/fix ace nonorthog #13

merged 2 commits into from
Aug 15, 2023

Conversation

swyant
Copy link
Member

@swyant swyant commented Aug 14, 2023

Still need to add tests, but this is now consistent with JuLIP potentials

@swyant swyant requested a review from emmanuellujan August 14, 2023 20:14
emmanuellujan
emmanuellujan approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@emmanuellujan emmanuellujan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a fresh Julia installation using Julia 1.9 + current version of PotentialLearning.jl + InteratomicBasisPotentials.jl from branch sw/fix_ace_nonorthog. I run example/Na/fit-dpp-ace-na.jl. It works well :)

@swyant swyant merged commit dd4fd57 into main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuellujan emmanuellujan emmanuellujan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swyant @emmanuellujan