This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
Tweaks #7
Closed
Tweaks #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placing a lifetime on OutputFile allows room for future support of in-memory encoding, and adjusting the names allows for improved consistency with the C++ and input APIs.
|
Ah! Sorry, Ralith, it looks like we were working concurrently, and I did a reorganization of the code into multiple files, so I can't directly merge. I like your changes here, so I'll manually make them the next chance I get. Thanks especially for catching the unused BTreeMap! I had put that in when playing around with ideas, and I guess later on in a tired stupor I didn't understand the complier warning and so just silenced it. Very silly if me. |
cessen
added a commit
that referenced
this pull request
May 20, 2017
Mainly naming changes, but also some code cleanup.
|
I believe I've ported over the changes that weren't made irrelevant by my work based on our discussion in #8. |
cessen
added a commit
that referenced
this pull request
May 22, 2017
Turns out the C++ flags were required. But hopefully this will work on the Travis CI server. Also updated readme to show Travis CI and crates.io badges.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to ignore the BTreeMap removal if you've got something planned for that.