Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1591 - updating dependencies, and committing yarn.lock file #558

Merged
merged 1 commit into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ _site/
*.rar
*.tar
*.zip
yarn.lock

# Logs and databases #
######################
Expand Down
4 changes: 2 additions & 2 deletions dist/ccdb5.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/ccdb5.css.map

Large diffs are not rendered by default.

123 changes: 61 additions & 62 deletions dist/ccdb5.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/ccdb5.js.map

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
"@babel/core": "^7.24.7",
"@babel/eslint-parser": "^7.24.7",
"@babel/preset-react": "^7.24.7",
"@babel/runtime": "^7.24.7",
"@cfpb/browserslist-config": "0.0.2",
"@cfpb/cfpb-design-system": "^3.2.2",
"@babel/runtime": "^7.26.0",
"@cfpb/browserslist-config": "0.0.3",
"@cfpb/cfpb-design-system": "3.2.2",
"@craco/craco": "^7.1.0",
"@csstools/postcss-sass": "^5.1.1",
"@csstools/sass-import-resolve": "^1.0.0",
Expand All @@ -52,7 +52,7 @@
"britecharts": "git+https://github.com/cfpb/britecharts.git#v2.4.2",
"coveralls": "^3.0.9",
"craco-esbuild": "^0.6.1",
"cypress": "^13.11.0",
"cypress": "^13.16.0",
"d3": "^7.9.0",
"dayjs": "^1.11.10",
"eslint": "^8.57.0",
Expand All @@ -61,9 +61,9 @@
"eslint-plugin-cypress": "^3.2.0",
"eslint-plugin-jsdoc": "^48.2.5",
"eslint-plugin-react-redux": "^4.1.0",
"highcharts": "9.2.2",
"highcharts": "11.4.8",
"history": "^5.3.0",
"husky": "^9.0.11",
"husky": "^9.1.7",
"identity-obj-proxy": "3.0.0",
"intro.js": "^7.2.0",
"intro.js-react": "1.0.0",
Expand All @@ -73,7 +73,7 @@
"mini-css-extract-plugin": "^2.9.0",
"mockdate": "^3.0.5",
"postcss": "^8.4.38",
"postcss-preset-env": "^9.5.13",
"postcss-preset-env": "^10.1.1",
"postcss-safe-parser": "^7.0.0",
"postcss-scss": "^4.0.9",
"prettier": "^3.3.1",
Expand Down
29 changes: 11 additions & 18 deletions src/components/Map/TileChartMap/TileChartMap.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ describe('TileChartMap', () => {
renderComponent();
expect(screen.getByTestId('tile-chart-map')).toBeInTheDocument();
expect(screen.getByTestId('tile-chart-map')).not.toHaveClass('print');
expect(
screen.getByText('Map of unspecified region with 1 data series.'),
).toBeInTheDocument();
});

it('renders print mode', () => {
Expand Down Expand Up @@ -71,8 +68,8 @@ describe('TileChartMap', () => {
expect(await screen.findByText('11,397')).toBeInTheDocument();

// need to mouseover to initialize the toggleState handler
fireEvent.mouseEnter(screen.getByLabelText('1. FL, value: 11,397.'));
fireEvent.click(screen.getByLabelText('1. FL, value: 11,397.'));
fireEvent.mouseEnter(screen.getByLabelText('FL, value: 11,397.'));
fireEvent.click(screen.getByLabelText('FL, value: 11,397.'));

expect(analyticsSpy).toHaveBeenCalledWith('State Event: add', 'FL');

Expand Down Expand Up @@ -110,20 +107,20 @@ describe('TileChartMap', () => {
expect(screen.getByTestId('tile-chart-map')).toBeInTheDocument();
expect(screen.getByTestId('tile-chart-map')).not.toHaveClass('print');

await screen.findByLabelText('1. FL, value: 11,397.');
await screen.findByLabelText('FL, value: 11,397.');

expect(screen.getByText('Complaints per 1,000')).toBeInTheDocument();
expect(screen.getByText('FL')).toBeInTheDocument();
expect(screen.getByText('0.56')).toBeInTheDocument();

// tooltip check
fireEvent.mouseEnter(screen.getByLabelText('1. FL, value: 11,397.'));
fireEvent.mouseEnter(screen.getByLabelText('FL, value: 11,397.'));

expect(
screen.getByText('Product with highest complaint volume'),
).toBeVisible();

fireEvent.click(screen.getByLabelText('1. FL, value: 11,397.'));
fireEvent.click(screen.getByLabelText('FL, value: 11,397.'));
expect(analyticsSpy).toHaveBeenCalledWith('State Event: add', 'FL');
expect(addStateFilterSpy).toHaveBeenCalledWith({
abbr: 'FL',
Expand Down Expand Up @@ -164,8 +161,8 @@ describe('TileChartMap', () => {
expect(await screen.findByText('11,397')).toBeInTheDocument();

// need to mouseEnter to initialize the toggleState handler!
fireEvent.mouseEnter(screen.getByLabelText('1. FL, value: 11,397.'));
fireEvent.click(screen.getByLabelText('1. FL, value: 11,397.'));
fireEvent.mouseEnter(screen.getByLabelText('FL, value: 11,397.'));
fireEvent.click(screen.getByLabelText('FL, value: 11,397.'));
expect(analyticsSpy).toHaveBeenCalledWith('State Event: remove', 'FL');
expect(removeStateFilterSpy).toHaveBeenCalledWith({
abbr: 'FL',
Expand Down Expand Up @@ -205,16 +202,12 @@ describe('TileChartMap', () => {
expect(await screen.findByText('FL')).toBeInTheDocument();
expect(await screen.findByText('0.56')).toBeInTheDocument();

expect(screen.getByLabelText('31. OK, value: 535.')).toHaveClass(
'deselected',
);
expect(screen.getByLabelText('1. FL, value: 11,397.')).toHaveClass(
'selected',
);
expect(screen.getByLabelText('OK, value: 535.')).toHaveClass('deselected');
expect(screen.getByLabelText('FL, value: 11,397.')).toHaveClass('selected');

// need to mouseEnter to initialize the toggleState handler!
fireEvent.mouseEnter(screen.getByLabelText('1. FL, value: 11,397.'));
fireEvent.click(screen.getByLabelText('1. FL, value: 11,397.'));
fireEvent.mouseEnter(screen.getByLabelText('FL, value: 11,397.'));
fireEvent.click(screen.getByLabelText('FL, value: 11,397.'));

expect(analyticsSpy).toHaveBeenCalledWith('State Event: remove', 'FL');
expect(removeStateFilterSpy).toHaveBeenCalledWith({
Expand Down
8 changes: 8 additions & 0 deletions src/components/Map/TileChartMap/TileMap/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,14 @@ class TileMap {
data = processMapData(data, scale);

const options = {
accessibility: {
description: '',
screenReaderSection: {
afterChartFormat: '',
beforeChartFormat: '',
},
},

bins,
chart: {
styledMode: true,
Expand Down
Loading