Tweak and consolidate date picker #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
anselmbradford
force-pushed
the
ans_ios_tweak
branch
from
62842a6
to
62cc483
Compare
contolini
reviewed
Nov 20, 2024
| @@ -35,6 +35,10 @@ textarea { | |||
| input[type='date'] { | |||
| appearance: textfield; | |||
| display: revert; | |||
|
|
|||
| &.a-text-input--full { | |||
| -webkit-min-logical-width: calc(100% - 16px); | |||
There was a problem hiding this comment.
Ok ok I went a min-width approach in c41101f
I realized the calc(100% - 16px) works on iOS, but then it is shorter on desktop browsers. Instead I set a min width/height to what it would be if the appearance was a textfield, and then set the appearance to none. This appears to look good across iOS Safari, desktop Safari, FF, and Chrome.
contolini
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge two date picker examples we had, and make a regular and full width example.
Changes
Testing