Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synk] Upgrade Packages #2243

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[Synk] Upgrade Packages #2243

merged 2 commits into from
Jul 29, 2024

Conversation

Michaeldremy
Copy link
Contributor

@Michaeldremy Michaeldremy commented Jul 25, 2024

Closes #2239

Tests passed on DEV ✅

sass was upgraded to the latest version of 1.77.8. A few of the .scss files had to be changed to support the following required changes.

Fixed a few React warnings in the OLARFT tool:

  • Unwrapped the p tag around ul tag for the Tips component
  • Adding unique keys to TableRows component mapping

Additionally the package react-fluid-table was unable to be upgraded due to the packages class names being changed and completely breaking the styling after the upgrade. See the following comment for the breaking changes.

…table WIP: OLARFT Styling seems to have broken, could be due to sass upgrade or react-fluid-table upgrade.Looking into fixing it.
…s related to class names being renamed due to package upgrade which is causing the styling to break.
Copy link
Contributor

@ojbravo ojbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Michaeldremy Michaeldremy merged commit c8b1d5b into master Jul 29, 2024
1 of 2 checks passed
@Michaeldremy Michaeldremy deleted the 2239-upgrade-packages branch July 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synk] Upgrade Packages
2 participants