Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Triage existing linting issues #1060

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Bug] Triage existing linting issues #1060

wants to merge 6 commits into from

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Nov 14, 2024 •
edited
Loading

Went through several linter issues and fixed most

Changes

  • Went through and found areas of easy linter improvements and fixed them.
  • Went through and found areas referencing this ticket and either fixed them, or put them under the umbrella of the post-mvp linter issues.

How to test this PR

  1. Read the notes
  2. Pull the branch for the sbl-frontend repo
  3. Restart the stack as necessary
  4. Check the github pipeline and make sure that linters are green
  5. Run the e2e tests and verify no new failures

Notes

  • There appears to be an unrelated test failure in the institution profile LEI status test

@tanner-ricks @github-advanced-security
Fix code scanning alert no. 8: Use of externally-controlled format st…
56b0901 
…ring

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@tanner-ricks tanner-ricks changed the title [Bug] Triage existing linting issues Draft: [Bug] Triage existing linting issues Nov 14, 2024
@tanner-ricks tanner-ricks marked this pull request as draft November 14, 2024 18:21
@tanner-ricks tanner-ricks marked this pull request as ready for review November 14, 2024 20:11
@tanner-ricks tanner-ricks changed the title Draft: [Bug] Triage existing linting issues [Bug] Triage existing linting issues Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tanner-ricks