Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention the unit of "len" in the Stream() function #28

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Mention the unit of "len" in the Stream() function #28

merged 2 commits into from
Dec 7, 2023

Conversation

jedisct1
Copy link
Collaborator

@jedisct1 jedisct1 commented Dec 7, 2023

Implementations can use a different unit, but when the function is used in other documents, having a well-defined unit is useful.

@jedisct1
Mention the unit of "len" in the Stream() function
26e19e9 
Implementations can use a different unit, but when the function
is used in other documents, having a well-defined unit is useful.
samuel-lucas6
samuel-lucas6 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@samuel-lucas6 samuel-lucas6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense. I've removed a comma to match previous Inputs: sections.

@jedisct1
Copy link
Collaborator Author

jedisct1 commented Dec 7, 2023

Thank you Samuel!

@jedisct1 jedisct1 merged commit c8143d5 into main Dec 7, 2023
@jedisct1 jedisct1 deleted the stream-units branch December 7, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-lucas6 samuel-lucas6 samuel-lucas6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedisct1 @samuel-lucas6