-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix off-by-one in P_MAX and A_MAX #46
Conversation
No problem. The AEGIS-256 description also has the issue, so one more place to update. draft-irtf-cfrg-aegis-aead/draft-irtf-cfrg-aegis-aead.md Lines 698 to 701 in 9cccd93
|
Also avoid the double parenthesis.
/cc @samuel-lucas6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't length MUST be less than P_MAX
and length MUST be less than A_MAX
(in Section 3.1 and 4.1) still be changed? Otherwise, the maximum is technically 261 - 2 bytes.
If I'm right about that, length MUST be less than C_MAX
and length MUST be less than A_MAX
should also be changed in Section 3.2 and 4.2.
Besides that, it looks ok. I'm not super keen on the brackets inside brackets, but there's not really anything you can do.
Ah, yes. That's right. Unrelated, thanks for the nice spec, I've been working on implementing 128L and 256, and it's been easy to do. |
Good catch, @samuel-lucas6 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Yawning!
Spotted by @Yawning, thanks!
Fixes #45