Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the CHANGELOG requirement in the PR template #1679

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Add the CHANGELOG requirement in the PR template #1679

merged 1 commit into from
Feb 20, 2023

Conversation

AlexV525
Copy link
Member

The comment would be an example. Related to #1662. This would be a temporary solution until we can have a robust check.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@AlexV525 AlexV525 requested a review from a team as a code owner February 20, 2023 12:56
@AlexV525 AlexV525 merged commit 9909245 into main Feb 20, 2023
@AlexV525 AlexV525 deleted the pr-template-changelog branch February 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexV525 @ueman