Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas check report in CI #2

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Add gas check report in CI #2

wants to merge 1 commit into from

Conversation

cgewecke
Copy link
Owner

@cgewecke cgewecke commented Jul 31, 2019

Hi, opening for further discussion...

Adds a "coveralls for gas" CI hook which reports the changes in gas consumption between a PR and it's target branch. (The hook is agnostic about whether gas increases are good/bad - it always succeeds.)

  • Updates eth-gas-reporter to ^0.2.9
  • Adds @codechecks/client dev dep (the CI service provider for the hook)
  • Adds an additional CI job as a fast-finish / optional failure. (Because gas monitoring causes tests to run > 2X more slowly and extra info is not critical)

What this looks like:

Further installation steps

  • enable this project at codechecks.io (free for open source)
  • paste a CC_SECRET env variable into the Travis settings for this repo

Things to consider...
The test suite here is industrial sized and this PR increases your CI overhead a bit. The gas reporter is a little slow because it makes extra data collection calls to the client. Hoping to change this soon and get it running as fast as normal tests. Even if you think this CI hook would be useful you might prefer to wait for performance improvements, idk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant