Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize multiframe demos #412

Merged
merged 64 commits into from
Sep 10, 2018

Conversation

Tobias1595
Copy link

Includes #406, fixes/answers #370 & #340, hopefully fixes #278

Condensed multi frame demos down to two:

  • MultiFrameAggregationDemo for aggregation mechanic
  • MultiFrameEffectsDemo for possible visual effects.

Tobias Knöschke added 30 commits June 29, 2017 12:13
  - Explicitly use transparency and noise kernels for multiple frames
  - Switch noise texture type from 3D to 2DArray
…loperate into reorganize_multiframe_demos

Conflicts:
	source/examples/demo-stages-plugins/MultiFramePostprocessingStage.cpp
	source/examples/demo-stages-plugins/MultiFrameSceneRenderingStage.cpp
Conflicts:
	source/examples/demo-stages-plugins/DemoMultiFrameAggregationPipeline.cpp
  + Remove texture extraction stages as textures are already aviable
  + Minor changes for readability
  - Use correct noise kernel type (fixes solid circles)
  - Add depth buffer (fixes blue always being on top)
  - Make circles' alpha value a uniform
Conflicts:
	source/examples/demo-stages-plugins/DemoMultiFrameAggregationPipeline.cpp
	source/examples/demo-stages-plugins/MultiFrameRenderingPipeline.cpp
	source/examples/demo-stages-plugins/MultiFrameRenderingPipeline.h
  - Use Quad instead of ScreenAlignedQuad
  - Set Output value of Geometry importer stage
  - Correctly connect stages and their dynamic slots
    > Use additional connections to trigger ClearStages
  + Remove viewport input from MultiFrameControlStage
WIP
  TODOs:
  - Why is SSAO effect so weak?
  - Better random value for transparency
  + Use pseudo-randomness shader code provided by Willy instead of noise
     texture
  - Remove commented code that has been replaced
  - Add include guard to random.glsl
  - Fix DiscDistributionKernel calculation
  - Add debug statements about multiframe aggregation progress
  - Fix aggregation halting one frame too early
  - Transparency demo is kept on purpose
…ltiframe_demos

Conflicts:
	data/gloperate/shaders/demos/transparency.frag
	source/examples/demo-stages-plugins/CMakeLists.txt
	source/examples/demo-stages-plugins/DemoMultiFrameAggregationPipeline.cpp
	source/examples/demo-stages-plugins/DemoMultiFrameEffectsPipeline.cpp
	source/examples/demo-stages-plugins/DemoMultiFrameEffectsPipeline.h
	source/examples/demo-stages-plugins/MultiFramePostprocessingStage.cpp
	source/examples/demo-stages-plugins/MultiFrameRenderingPipeline.cpp
	source/examples/demo-stages-plugins/MultiFrameRenderingPipeline.h
	source/examples/demo-stages-plugins/MultiFrameSceneRenderingStage.cpp
	source/examples/demo-stages-plugins/TransparencyRenderingPipeline.cpp
	source/examples/demo-stages-plugins/TransparencyRenderingPipeline.h
	source/examples/demo-stages-plugins/TransparentCirclesStage.cpp
	source/gloperate-glkernel/source/stages/MultiFrameAggregationPipeline.cpp
	source/gloperate-glkernel/source/stages/MultiFrameControlStage.cpp
Tobias Knöschke added 22 commits September 12, 2017 10:26
  + Reimplement MultiFrameEffectDemo based on this

(cherry picked from commit 4af1f00)
  + Remove underscores from variable some names

(cherry picked from commit ea5c852)
  - Add some options to MF effect & aggregation demos' inputs
  - Fix MF aggregation aggregating one frame less than specified
  - Added cppexpose::EnumDefaultStrings<LightType>
  - Changed LightTestPipeline accordingly
…write

Conflicts:
	source/examples/demo-stages-plugins/LightTestPipeline.cpp
	source/examples/demo-stages-plugins/LightTestPipeline.h
  - Fix illumination from backside
  - Make MF effect config slots members instead of creating them dynamically
  - Add, move & adapt various comments
  - Work towards naming & formatting consistency
  - Re-sort uniforms
  - Remove uniform default values
  - Add some comments
  - Use operator= instead of setValue in pipelines
  - Add comments in light and transparency demo shaders
  - Randomize sample distances
  - Increase kernel size even more
  - Randomize sample order in kernel
  - Add intensity parameter
  - Tweak default parameters
@Tobias1595 Tobias1595 changed the title [WIP] Reorganize multiframe demos Reorganize multiframe demos Oct 12, 2017
@scheibel scheibel merged commit 0e90385 into cginternals:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DemoSSAOPipeline suffers from heavy flickering
2 participants