Skip to content

Commit

Permalink
Remove scale_shape_manual link
Browse files Browse the repository at this point in the history
  • Loading branch information
cgoo4 committed Jul 6, 2024
1 parent 9d10e47 commit 578c9b9
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
4 changes: 2 additions & 2 deletions R/geom_casting.R
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#' By default, the "violin" shape is used.
#'
#' If the shape is mapped to a variable, e.g. `aes(shape = factor(cyl))`, then
#' [scale_shape_manual()] is also required to explicitly name the desired
#' `scale_shape_manual()` is also required to explicitly name the desired
#' shapes as a character vector (see examples). This is because standard
#' shapes are associated with a number, e.g. a circle is 19, whereas
#' `geom_casting()` shapes are associated only with character strings.
Expand Down Expand Up @@ -83,7 +83,7 @@ geom_casting <- \(mapping = NULL, data = NULL,
#' @description `r lifecycle::badge('experimental')`
#'
#' Create a data frame of available shapes and associated sets. This may be
#' filtered and used as a vector of strings in `scale_shape_manual`.
#' filtered and used as a vector of strings in `scale_shape_manual()`.
#'
#' @export
#'
Expand Down
8 changes: 7 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@

* 0 errors | 0 warnings | 0 notes

## Resubmission

* Wrapped scale_shape_manual() with backticks instead of square brackets (link)
in geom_casting.R roxygen2 comments.

## revdepcheck results

We checked 0 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 0 reverse dependencies, comparing R CMD check results across CRAN and
dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
Expand Down
2 changes: 1 addition & 1 deletion man/geom_casting.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/shapes_cast.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 578c9b9

Please sign in to comment.