Skip to content

Commit

Permalink
Merge pull request #1675 from frankrousseau/main
Browse files Browse the repository at this point in the history
Main
  • Loading branch information
frankrousseau authored Jan 22, 2025
2 parents 89ddc02 + ed4407e commit c0ea744
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 3 deletions.
2 changes: 2 additions & 0 deletions src/components/lists/TaskList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,7 @@ export default {
this.$t('tasks.fields.entity_name'),
this.$t('tasks.fields.task_status'),
this.$t('tasks.fields.assignees'),
this.$t('tasks.fields.difficulty'),
this.$t('tasks.fields.estimation'),
this.$t('tasks.fields.duration'),
this.$t('tasks.fields.retake_count'),
Expand Down Expand Up @@ -904,6 +905,7 @@ export default {
this.getEntity(task.entity.id).name,
task.task_status_short_name,
assignees,
task.difficulty,
this.formatDuration(task.estimation),
this.formatDuration(task.duration),
task.retake_count,
Expand Down
1 change: 1 addition & 0 deletions src/components/mixins/annotation.js
Original file line number Diff line number Diff line change
Expand Up @@ -1291,6 +1291,7 @@ export const annotationMixin = {
* Remove all drawing objects from the fabric canvas
*/
clearCanvas() {
this.endAnnotationSaving()
if (this.fabricCanvas) {
this.fabricCanvas.clear()
}
Expand Down
2 changes: 2 additions & 0 deletions src/components/mixins/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -739,6 +739,7 @@ export const playerMixin = {

onProgressChanged(frameNumber, updatePlaylistProgress = true) {
this.clearCanvas()
this.reloadAnnotations()

if (this.isCurrentPreviewPicture) {
this.framesSeenOfPicture = frameNumber + 1
Expand Down Expand Up @@ -961,6 +962,7 @@ export const playerMixin = {
) {
this.onAnnotateClicked()
} else if ((event.ctrlKey || event.metaKey) && event.keyCode === 90) {
event.preventDefault()
this.undoLastAction()
} else if (event.altKey && event.keyCode === 82) {
this.redoLastAction()
Expand Down
4 changes: 4 additions & 0 deletions src/components/mixins/previewRoom.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ export const previewRoomMixin = {
},

methods: {
isValidRoomId(value) {
return value && value !== 'temp'
},

openRoom() {
this.$socket.emit('preview-room:open-playlist', {
playlist_id: this.room.id
Expand Down
2 changes: 1 addition & 1 deletion src/components/modals/ViewPlaylistModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default {
previewFileEntityMap: new Map(),
currentEntities: {},
currentPlaylist: {
id: '',
id: 'temp',
name: 'Temporary playlist',
shots: [],
for_entity: 'shot'
Expand Down
2 changes: 1 addition & 1 deletion src/components/pages/Edit.vue
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
@open-room="openRoom"
@join-room="joinRoom"
@leave-room="leaveRoom"
v-if="currentEdit?.id && currentPreview?.id"
v-if="isValidRoomId(currentEdit?.id) && currentPreview?.id"
/>
</div>
</div>
Expand Down
4 changes: 3 additions & 1 deletion src/components/pages/playlists/PlaylistPlayer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
@open-room="openRoom"
@join-room="joinRoom"
@leave-room="leaveRoom"
v-if="playlist.id && !isFullMode"
v-if="isValidRoomId(playlist.id) && !isFullMode"
/>
<button-simple
class="playlist-button topbar-button flexrow-item full-button"
Expand Down Expand Up @@ -1563,6 +1563,7 @@ export default {
width: this.currentPreview.width,
height: this.currentPreview.height
}
this.loadAnnotation(this.getAnnotation(0))
}
},
Expand Down Expand Up @@ -1698,6 +1699,7 @@ export default {
if (this.isWaveformDisplayed) {
height -= 60
}
if (this.$refs['video-container']) {
this.$refs['video-container'].style.height = `${height}px`
}
Expand Down
3 changes: 3 additions & 0 deletions src/components/previews/VideoViewer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,9 @@ export default {
this.resetPanZoom()
this.maxDuration = '00:00.000'
this.pause()
this.$nextTick(() => {
this.resetPanZoom()
})
},
light() {
Expand Down

0 comments on commit c0ea744

Please sign in to comment.