Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concepts page #1247

Merged
merged 41 commits into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
ab77aeb
[concepts] init new page
NicoPennec Nov 21, 2023
c5e7d97
[concepts] add new type of Task Status
NicoPennec Nov 21, 2023
23d3e30
[concepts] add new section on Topbar menu
NicoPennec Nov 21, 2023
1a12912
[concepts] init data store
NicoPennec Nov 21, 2023
7ffc43b
[concepts] add create concept
NicoPennec Nov 22, 2023
4c6d0fe
[concepts] add load concepts
NicoPennec Nov 23, 2023
c7e9bbd
[concepts] update list of concepts
NicoPennec Nov 28, 2023
026ae66
[concepts] update task panel to support the concepts
NicoPennec Nov 28, 2023
9d3b4c4
[concepts] fix concept creation
NicoPennec Nov 29, 2023
cc4b3d9
[concepts] fix concept selection
NicoPennec Nov 30, 2023
6631638
[concepts] add delete concepts
NicoPennec Dec 1, 2023
c41becb
[concepts] add asset tagging
NicoPennec Dec 7, 2023
c93c565
[concepts] list linked concepts in Asset view
NicoPennec Dec 8, 2023
c221773
[concepts] fix task status edition
NicoPennec Dec 11, 2023
71c6c5e
[concepts] fix UI for the new API data
NicoPennec Dec 11, 2023
1aa1d40
[concepts] fix UI for the new API data
NicoPennec Dec 12, 2023
dd6b048
[concepts] fix loading of concepts
NicoPennec Dec 12, 2023
e6a65de
[concepts] add concept links
NicoPennec Dec 12, 2023
f6f6c11
[concepts] fix typo
NicoPennec Dec 12, 2023
f1b5899
[concepts] allow multiple creation of concepts at once
NicoPennec Dec 12, 2023
64119e0
[concepts] fix sorted by
NicoPennec Dec 12, 2023
2f3861f
[concepts] fix linked concepts in Asset page
NicoPennec Dec 13, 2023
7301743
[concepts] hide notifications in action panel
NicoPennec Dec 13, 2023
9a399d6
[concepts] fix UI for the new API data
NicoPennec Dec 14, 2023
49dba1a
[concepts] add the remove link action on preview player
NicoPennec Dec 14, 2023
cb507e9
[concepts] fix linked concepts in Asset page
NicoPennec Dec 15, 2023
3292810
[concepts] fix css
NicoPennec Dec 15, 2023
73fe222
[concepts] fix concept filters
NicoPennec Dec 15, 2023
05db12b
[concepts] enable links search in action panel
NicoPennec Dec 15, 2023
c6b7337
[concepts] hide assignation from action panel
NicoPennec Dec 15, 2023
28ed8b9
[concepts] show assigner instead of assignees
NicoPennec Dec 15, 2023
77d5f6f
[concepts] fix linked concepts in Asset page
NicoPennec Dec 15, 2023
2d59502
[concepts] hide task type used by Concepts
NicoPennec Dec 18, 2023
a8c6bd5
[concepts] fix export action
NicoPennec Dec 18, 2023
a3e71e8
[concepts] update publisher filtering with created_by field
NicoPennec Dec 18, 2023
ac75dca
[concepts] allow a concept publisher to edit or delete these entries
NicoPennec Dec 18, 2023
212e316
[concepts] fix concept filtering in Asset page
NicoPennec Dec 18, 2023
86e0b89
[concepts] update styles for dark theme
NicoPennec Dec 18, 2023
bd3350a
[concepts] rename attribute according api
NicoPennec Dec 18, 2023
5141b8f
[concepts] fix styles
NicoPennec Dec 18, 2023
cd6eb60
[concepts] update link to linked entity
NicoPennec Dec 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,31 @@ h2 {
color: $blue;
}

.tags {
.tag {
background: var(--background-tag);
color: var(--text);

a {
color: var(--text);
}

.action {
cursor: pointer;
background: $light-grey;
color: white;

.dark & {
background: $dark-grey;
}

&:hover {
background: $dark-grey-lighter;
}
}
}
}

.timecode {
border: 1px solid $blue;
border-radius: 5px;
Expand Down
7 changes: 6 additions & 1 deletion src/components/lists/TaskStatusList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
<th scope="col" class="is-feedback-request">
{{ $t('task_status.fields.is_feedback_request') }}
</th>
<th scope="col" class="is-concept">
{{ $t('task_status.fields.for_concept') }}
</th>
<th scope="col" class="actions"></th>
</tr>
</thead>
Expand All @@ -52,6 +55,7 @@
class="is-feedback-request"
:value="entry.is_feedback_request"
/>
<boolean-cell class="is-concept" :value="entry.for_concept" />
<row-actions-cell
:entry-id="entry.id"
:hide-delete="entry.is_default === true"
Expand Down Expand Up @@ -138,7 +142,8 @@ export default {
.is-retake,
.is-artist-allowed,
.is-client-allowed,
.is-feedback-request {
.is-feedback-request,
.is-concept {
text-align: center;
width: 140px;
min-width: 140px;
Expand Down
7 changes: 2 additions & 5 deletions src/components/lists/TaskTypeList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,9 @@
</template>

<script>
import { mapGetters, mapActions } from 'vuex'
import { mapGetters } from 'vuex'
import draggable from 'vuedraggable'

import BooleanRep from '@/components/widgets/BooleanRep'
import DepartmentName from '@/components/widgets/DepartmentName.vue'
import RowActionsCell from '@/components/cells/RowActionsCell'
Expand Down Expand Up @@ -296,8 +297,6 @@ export default {
TaskTypeCell
},

mounted() {},

computed: {
...mapGetters(['getDepartments']),

Expand All @@ -323,8 +322,6 @@ export default {
},

methods: {
...mapActions([]),

getTaskTypesForEntity(entity) {
return this.entries.filter(taskType => taskType.for_entity === entity)
},
Expand Down
38 changes: 29 additions & 9 deletions src/components/modals/AddPreviewModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
{{ $t('tasks.change_preview') }}
</h1>
<h1 class="title" v-else>
{{ $t('tasks.add_preview') }}
{{ isConcept ? $t('concepts.add_concept') : $t('tasks.add_preview') }}
</h1>

<p>
Expand All @@ -25,15 +25,19 @@
<file-upload
ref="preview-field"
:accept="extensions"
:multiple="true"
:multiple="isMultiple"
:label="$t('main.select_file')"
:is-primary="false"
@fileselected="onFileSelected"
hide-file-names
/>

<p class="error" v-if="isError">
{{ $t('tasks.add_preview_error') }}
{{
isConcept
? $t('concepts.add_concept_error')
: $t('tasks.add_preview_error')
}}
</p>

<h3 class="subtitle has-text-centered" v-if="forms.length > 0">
Expand Down Expand Up @@ -73,9 +77,9 @@
</template>
</p>

<div class="mt1 message">
<div class="mt1 message" v-if="message">
<div class="message-body">
{{ $t('tasks.revision_preview_file') }}
{{ $t(message) }}
</div>
</div>

Expand All @@ -89,7 +93,11 @@
}"
@click="$emit('confirm', forms)"
>
{{ $t('tasks.add_revision_confirm') }}
{{
isConcept
? $t('main.confirmation')
: $t('tasks.add_revision_confirm')
}}
</a>
<button @click="$emit('cancel')" class="button is-link">
{{ $t('main.cancel') }}
Expand Down Expand Up @@ -119,22 +127,34 @@ export default {
type: Boolean,
default: false
},
isLoading: {
isConcept: {
type: Boolean,
default: false
},
isEditing: {
type: Boolean,
default: false
},
isError: {
type: Boolean,
default: false
},
isEditing: {
isLoading: {
type: Boolean,
default: false
},
isMultiple: {
type: Boolean,
default: true
},
extensions: {
type: String,
default: files.ALL_EXTENSIONS_STRING
},
message: {
type: String,
default: 'tasks.revision_preview_file'
},
title: {
type: String,
default: ''
Expand All @@ -159,7 +179,7 @@ export default {
...mapActions([]),

onFileSelected(forms) {
this.forms = this.forms.concat(forms)
this.forms = this.isMultiple ? this.forms.concat(forms) : [forms]
this.$emit('fileselected', this.forms)
},

Expand Down
20 changes: 15 additions & 5 deletions src/components/modals/EditCommentModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
</h1>

<form @submit.prevent>
<combo-box-status
<combobox-status
:label="$t('task_status.title')"
:task-status-list="taskStatusForCurrentUser"
:task-status-list="taskStatuses"
v-model="form.task_status_id"
/>

Expand Down Expand Up @@ -157,7 +157,7 @@ import { XIcon } from 'vue-feather-icons'

import AtTa from 'vue-at/dist/vue-at-textarea'
import Checklist from '@/components/widgets/Checklist'
import ComboBoxStatus from '@/components/widgets/ComboboxStatus.vue'
import ComboboxStatus from '@/components/widgets/ComboboxStatus.vue'
import FileUpload from '@/components/widgets/FileUpload'
import ModalFooter from '@/components/modals/ModalFooter'
import PeopleAvatar from '@/components/widgets/PeopleAvatar'
Expand All @@ -168,7 +168,7 @@ export default {
components: {
AtTa,
Checklist,
ComboBoxStatus,
ComboboxStatus,
FileUpload,
ModalFooter,
PeopleAvatar,
Expand Down Expand Up @@ -228,7 +228,17 @@ export default {
'isCurrentUserClient',
'productionDepartmentIds',
'taskStatusForCurrentUser'
])
]),

taskStatuses() {
return this.taskStatusForCurrentUser.filter(
status => Boolean(status.for_concept) === this.isConceptTask
)
},

isConceptTask() {
return this.$route.path.includes('concept')
}
},

methods: {
Expand Down
7 changes: 7 additions & 0 deletions src/components/modals/EditTaskStatusModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@
v-model="form.is_feedback_request"
v-if="form.is_default === 'false'"
/>
<boolean-field
:label="$t('task_status.fields.for_concept')"
@enter="confirmClicked"
v-model="form.for_concept"
v-if="form.is_default === 'false'"
/>

<color-field
ref="colorField"
Expand Down Expand Up @@ -218,6 +224,7 @@ export default {
is_feedback_request: String(
this.taskStatusToEdit.is_feedback_request || false
),
for_concept: String(this.taskStatusToEdit.for_concept || false),
archived: String(this.taskStatusToEdit.archived || false)
}
}
Expand Down
Loading