Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #1261

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Various fixes #1261

merged 3 commits into from
Dec 11, 2023

Conversation

frankrousseau
Copy link
Contributor

Problem

  • The asset list layout is clumsy.
  • Annotations on pictures are broken when a video is displayed first.
  • When getting into production, the asset page is always displayed by default. At some point in the production, it would be great that the shot page to become the default one.

Solution

  • Put the loader and the no asset picture into the datable div wrapper
  • Always use 0 as time for pictures annotations (saving / loading) and react to reset size event only if it comes from the right source in the player.
  • Add the homepage field in the production parameters and use it to set the production links in the open production page.

@EvanBldy EvanBldy merged commit 8b111c0 into cgwire:master Dec 11, 2023
5 checks passed
homepage: {
'assets': 'Assets',
'shots': 'Shots',
'sequences': 'sequences',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:

Suggested change
'sequences': 'sequences',
'sequences': 'Sequences',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants