Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #1266

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Various fixes #1266

merged 3 commits into from
Dec 19, 2023

Conversation

frankrousseau
Copy link
Contributor

@frankrousseau frankrousseau commented Dec 18, 2023 •
edited
Loading

Problem

  • The timestamp displayed doesn't conform to the SMPTE standards.
  • The frame tagging adds an extra frame.

Solution

  • Apply the standard rendering to the preview player
  • Use the right frame computation during the frame tagging

@NicoPennec NicoPennec merged commit 4badc6c into cgwire:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankrousseau @NicoPennec