Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing Improvements | PSBrush Library for pressure sensitivity / Shortcuts to jump between drawings | Squash into Single Commit rebased on latest upstream #1655

Closed

Conversation

tetsuoanimation
Copy link
Contributor

@tetsuoanimation tetsuoanimation commented Jan 9, 2025

Problem:

  • PR 1649 had a history / multiple commits

Solution:

  • Squash merge into recreated branch so there's only a single commit for this feature.

Original PR below

Problem

  • There is no pressure sensitivity when drawing with a pen
  • There is no way to jump between drawings

Solution

  • Implement PSBrush library
  • Implement , and . to jump between drawings

@frankrousseau
Copy link
Contributor

Thank you but I have one additional question. Why the annotation.js file is entirely rewritten. It's hard to review changes.

@tetsuoanimation
Copy link
Contributor Author

Thank you but I have one additional question. Why the annotation.js file is entirely rewritten. It's hard to review changes.

I think that's trailing whitespace that my compare ignored - let me see what I can do.

@frankrousseau
Copy link
Contributor

It's the same for the PreviewPlayer file.

@tetsuoanimation
Copy link
Contributor Author

tetsuoanimation commented Jan 9, 2025

Yeah - ignoring whitespace when comparing works - adding ?w=1 on the link on github does that: https://github.com/cgwire/kitsu/pull/1655/files?w=1

@frankrousseau
Copy link
Contributor

Ok I will work on this on my code directly if you don't mind to avoid the unreadable diff in the git history.

@tetsuoanimation
Copy link
Contributor Author

tetsuoanimation commented Jan 9, 2025

Ok I will work on this on my code directly if you don't mind to avoid the unreadable diff in the git history.

Oh that's totally fine :)
I found this for git && whitespace but I am not sure it is helpful - I'll leave it here for other stuff https://stackoverflow.com/questions/9776527/merging-without-whitespace-conflicts

@tetsuoanimation
Copy link
Contributor Author

tetsuoanimation commented Jan 9, 2025

@frankrousseau I just merged the changes to get the requested mouse pressure sensitivity fake into this one :)
I hardcoded the algorithm to 'fade' which felt best to me - you can switch them by setting the
mouseDrawingPressureMode to "fade", "distance" or null

…e, switched calculation to canvas relative to support high res displays, tweaked values to look and feel more like a pen
@frankrousseau
Copy link
Contributor

I'm closing this PR in favor of mine which is cleaner from a diff perspective. #1657

Thank you a lot @tetsuoanimation for this great addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants