Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gptm32 implementation for ch32v20x chips that support it #14

Closed
wants to merge 3 commits into from

Conversation

marti157
Copy link
Contributor

The following chips have a 32-bit GPTM (on TIM5):

  • ch32v203rbt6
  • ch32v208cbu6
  • ch32v208gbu6
  • ch32v208rbt6
  • ch32v208wbu6

When building for these chips, there is an error due to TimerBits::Bits32 not being conditionally compiled.

Let me know if there's a better way to fix this other than adding a cfg flag, thanks

@andelf
Copy link
Contributor

andelf commented May 13, 2024

Thanks for the fix

andelf added 2 commits May 13, 2024 22:37
- Add chip name cfg flag
- Use chip family & chip name flags to guard special peripherals
@andelf
Copy link
Contributor

andelf commented May 13, 2024

I reworked it a little:

  • Use chip names as feature flags of special peripherals for now. (I might need to refer stm32-data in the future for a better solution)
  • Add CH32V208 to the examples directory, at least make it builds

@andelf andelf closed this May 13, 2024
@andelf
Copy link
Contributor

andelf commented May 13, 2024

This is already merged by commits. The "Closed" state is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants