-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.3V and 5V output control #72
Conversation
Debug done. |
src/main.rs
Outdated
/// Enable 5V output | ||
Enable5v {}, | ||
/// Disable 5V output | ||
Disable5v {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better make them grouped into a SetPower(commands::SetPower)
sub-command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for review.
I grouped them into sub-command.
Detail: 35b3713
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Approved.
I added these commands, and already tested on WCH-LinkE.
example
When merge this PR, I recommend that squash and merge.