Merge pull request #219 from austince/fix/inherited-properties

fix(inherited properties): Allow for status / statusCode to exist on the prototype
chaijs · Aug 1, 2018 · d515691 · d515691
2 parents 1af976d + 5de4b03
commit d515691
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,6 @@
 node_modules
 coverage/
+
+# IDEs
+.idea
+.vscode
diff --git a/lib/http.js b/lib/http.js
@@ -77,7 +77,16 @@ module.exports = function (chai, _) {
    */
 
   Assertion.addMethod('status', function (code) {
-    new Assertion(this._obj).to.have.any.keys('status', 'statusCode');
+    var hasStatus = Boolean('status' in this._obj || 'statusCode' in this._obj);
+    new Assertion(hasStatus).assert(
+        hasStatus
+        , "expected #{act} to have keys 'status', or 'statusCode'"
+        , null // never negated
+        , hasStatus // expected
+        , this._obj // actual
+        , false // no diff
+    );
+
     var status = this._obj.status || this._obj.statusCode;
 
     this.assert(

diff --git a/test/http.js b/test/http.js
@@ -18,6 +18,13 @@ describe('assertions', function () {
     res.should.to.have.status(200);
   });
 
+  it('#status property "status" should work with inheritance', function () {
+    function TestError() {};
+    TestError.prototype.status = 404;
+    var testError = new TestError();
+    testError.should.have.status(404);
+  });
+
   it('#ip', function () {
     '127.0.0.1'.should.be.an.ip;
     '2001:0db8:85a3:0000:0000:8a2e:0370:7334'.should.be.an.ip;