Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Introduce Node Subtasks #103

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Re-Introduce Node Subtasks #103

merged 1 commit into from
Apr 18, 2024

Conversation

Jurshsmith
Copy link
Member

@Jurshsmith Jurshsmith commented Apr 18, 2024

This change renames add_task to add_subtask to remove name conflict with NodeTask.

More importantly, it allows borrowing the JoinHandle returned from tokio to keep task supervisors in charge of added tasks while Chaindexing's node task orchestration optionally restarts them.

@Jurshsmith Jurshsmith added the enhancement New feature or request label Apr 18, 2024
This change renames `add_task` to `add_subtask` to remove name
conflict with `NodeTask`.

More importantly, it allows borrowing the JoinHandle returned from `tokio` to keep
task supervisors in charge of added tasks while Chaindexing's node task orchestration
optionally restarts them.
@Jurshsmith Jurshsmith merged commit f4c82cc into main Apr 18, 2024
4 checks passed
@Jurshsmith Jurshsmith deleted the improve-node-tasks branch April 18, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant