Skip to content

Commit

Permalink
change bad rollout to non-paging (#613)
Browse files Browse the repository at this point in the history
the idea is that the rollout is triggered by someone, and that person
would be aware of it, so no need to further page.
this also supports individual stage/service rolling which may not be
worthwhile to alert.

we may revisit this and have it page for critical services like
api/issuer/datastore

Signed-off-by: Kenny Leung <[email protected]>
  • Loading branch information
k4leung4 authored Oct 29, 2024
1 parent 93011e1 commit 7c75d58
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/alerting/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ resource "google_monitoring_alert_policy" "bad-rollout" {
}
}

notification_channels = length(var.notification_channels) != 0 ? var.notification_channels : local.oncall
notification_channels = length(var.notification_channels) != 0 ? var.notification_channels : local.slack

enabled = "true"
project = var.project_id
Expand Down

0 comments on commit 7c75d58

Please sign in to comment.