Skip to content

Commit

Permalink
Switch regional-go-service to use the Cloud Run default (#49)
Browse files Browse the repository at this point in the history
Previously we defaulted to `h2c` (http/2 without TLS) and that doesn't
play nicely with Cloud Events go-sdk.

Signed-off-by: Matt Moore <[email protected]>
  • Loading branch information
mattmoor authored Dec 24, 2023
1 parent 345c3e9 commit fe6b5e9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion regional-go-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ No requirements.

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_containers"></a> [containers](#input\_containers) | The containers to run in the service. Each container will be run in each region. | <pre>map(object({<br> source = object({<br> base_image = optional(string, "cgr.dev/chainguard/static:latest-glibc")<br> working_dir = string<br> importpath = string<br> })<br> args = optional(list(string), [])<br> ports = optional(list(object({<br> name = optional(string, "h2c")<br> container_port = number<br> })), [])<br> env = optional(list(object({<br> name = string<br> value = string<br> })), [])<br> regional-env = optional(list(object({<br> name = string<br> value = map(string)<br> })), [])<br> volume_mounts = optional(list(object({<br> name = string<br> mount_path = string<br> })), [])<br> }))</pre> | n/a | yes |
| <a name="input_containers"></a> [containers](#input\_containers) | The containers to run in the service. Each container will be run in each region. | <pre>map(object({<br> source = object({<br> base_image = optional(string, "cgr.dev/chainguard/static:latest-glibc")<br> working_dir = string<br> importpath = string<br> })<br> args = optional(list(string), [])<br> ports = optional(list(object({<br> name = optional(string, "http1")<br> container_port = number<br> })), [])<br> env = optional(list(object({<br> name = string<br> value = string<br> })), [])<br> regional-env = optional(list(object({<br> name = string<br> value = map(string)<br> })), [])<br> volume_mounts = optional(list(object({<br> name = string<br> mount_path = string<br> })), [])<br> }))</pre> | n/a | yes |
| <a name="input_egress"></a> [egress](#input\_egress) | The egress mode for the service. Must be one of ALL\_TRAFFIC, or PRIVATE\_RANGES\_ONLY. Egress traffic is routed through the regional VPC network from var.regions. | `string` | `"ALL_TRAFFIC"` | no |
| <a name="input_ingress"></a> [ingress](#input\_ingress) | The ingress mode for the service. Must be one of INGRESS\_TRAFFIC\_ALL, INGRESS\_TRAFFIC\_INTERNAL\_LOAD\_BALANCER, or INGRESS\_TRAFFIC\_INTERNAL\_ONLY. | `string` | `"INGRESS_TRAFFIC_INTERNAL_ONLY"` | no |
| <a name="input_name"></a> [name](#input\_name) | n/a | `string` | n/a | yes |
Expand Down
2 changes: 1 addition & 1 deletion regional-go-service/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ variable "containers" {
})
args = optional(list(string), [])
ports = optional(list(object({
name = optional(string, "h2c")
name = optional(string, "http1")
container_port = number
})), [])
env = optional(list(object({
Expand Down

0 comments on commit fe6b5e9

Please sign in to comment.