Add an in-process otel collector #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will automatically scrape prometheus metrics and send to GMP. Signed-off-by: Nghia Tran <[email protected]>
mattmoor
reviewed
Dec 20, 2023
mattmoor
reviewed
Dec 21, 2023
Signed-off-by: Matt Moore <[email protected]>
mattmoor
reviewed
Dec 21, 2023
Signed-off-by: Matt Moore <[email protected]>
mattmoor
reviewed
Dec 21, 2023
| ) | ||
|
|
||
| var ( | ||
| //go:embed default.yaml |
There was a problem hiding this comment.
Are you sure this works indented like this? 🤔
All of the //go: directives I'm used to seeing start at the beginning of the line...
There was a problem hiding this comment.
Yes, I confirmed that this works in my dev environment.
Signed-off-by: Nghia Tran <[email protected]>
Signed-off-by: Nghia Tran <[email protected]>
Signed-off-by: Nghia Tran <[email protected]>
Signed-off-by: Nghia Tran <[email protected]>
mattmoor
approved these changes
Dec 22, 2023
tcnghia
added a commit
that referenced
this pull request
Dec 22, 2023
Reverts #19 Going to add a simple sidecar wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically scrape prometheus metrics and send to GMP.