Add gRPC (inbound) #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Tran <[email protected]>
imjasonh
approved these changes
Dec 22, 2023
mattmoor
reviewed
Dec 23, 2023
| variable "grpc_service_name" { | ||
| description = "Name of the GRPC service(s) to monitor" | ||
| type = string | ||
| default = "" |
There was a problem hiding this comment.
I don't think we should have a default here
mattmoor
reviewed
Dec 23, 2023
| title = "Incoming request latency" | ||
| filter = concat(var.filter, [ | ||
| "metric.type=\"prometheus.googleapis.com/grpc_server_handling_seconds/histogram\"", | ||
| "metric.label.\"grpc_service\"=monitoring.regex.full_match(\"chainguard.datastore.*\")", |
There was a problem hiding this comment.
hmm chainguard.datastore here seems wrong.
mattmoor
reviewed
Dec 23, 2023
Comment on lines
+39
to
+57
| module "outbound_request_count" { | ||
| source = "../../widgets/xy" | ||
| title = "Request count" | ||
| filter = concat(var.filter, [ | ||
| "metric.type=\"prometheus.googleapis.com/grpc_server_handled_total/counter\"", | ||
| "metric.label.grpc_service=monitoring.regex.full_match(\"${var.grpc_service_name}.*\")", | ||
| ]) | ||
| group_by_fields = [ | ||
| "metric.label.\"grpc_service\"", | ||
| "metric.label.\"grpc_method\"", | ||
| "metric.label.\"grpc_code\"" | ||
| ] | ||
| primary_align = "ALIGN_RATE" | ||
| primary_reduce = "REDUCE_NONE" | ||
| secondary_align = "ALIGN_NONE" | ||
| secondary_reduce = "REDUCE_SUM" | ||
| } | ||
|
|
||
| module "outbound_latency" { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our gRPC metrics dp not have the right label
service_nameyet. That means we can't have outbound gRPC widgets (which would need to distinguish by caller i.e.service_name).I'm using the
grpc_service_namevariable as a work around here. Will remove it and add outbound gRPC when the metric label is fixed.