-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gke module #540
add gke module #540
Conversation
do you want to address the wiz findings? |
This would be really helpful I don't have access to the wiz scans (requested) but happy to take a look if someone pastes the details terrascan picks up the 0.0.0.0 in https://cloud.google.com/kubernetes-engine/docs/concepts/network-isolation#limitations-ip-endpoints
|
Signed-off-by: Pris Nasrat <[email protected]>
|
terraform { | ||
required_providers { | ||
google = { | ||
source = "hashicorp/google" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version is typical needed at call sight,
so no need here.
@@ -0,0 +1,117 @@ | |||
variable "name" {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be good to add the description and type for all missing ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for reviewing the wiz warnings
adds a reusable GKE module