Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gke module #540

Merged
merged 2 commits into from
Dec 3, 2024
Merged

add gke module #540

merged 2 commits into from
Dec 3, 2024

Conversation

joshrwolf
Copy link
Contributor

adds a reusable GKE module

@wiz-inc-643c6df573
Copy link

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 1 4 0 5
Vulnerabilities 0 0 0 0 0 0
Secrets 0 0 0 0 0 0
Total 0 0 1 4 0 5

View scan details in Wiz

@k4leung4
Copy link
Contributor

do you want to address the wiz findings?

@pnasrat
Copy link
Member

pnasrat commented Nov 27, 2024

This would be really helpful I don't have access to the wiz scans (requested) but happy to take a look if someone pastes the details

terrascan picks up the 0.0.0.0 in master_authorized_networks_config I suspect that is set as we fall under the documented limitations of ip endpoints:

https://cloud.google.com/kubernetes-engine/docs/concepts/network-isolation#limitations-ip-endpoints

If you have clients connecting from networks with dynamic IP addresses, such as employees on home networks, you must update the list of authorized networks frequently to maintain access to the cluster.

@pnasrat
Copy link
Member

pnasrat commented Nov 29, 2024

  1. GKE cluster should have a Pod Security Policy enabled - deprecated in 1.25 so false positive
  2. GKE cluster network policy should be enabled - implied by ADVANCED_DATAPATH false positive
  3. GKE cluster basic authentication should be disabled - removed in 1.19 false positive
  4. GKE cluster should have label information - nodes labeled in dynamic block, added squad/name resource labels
  5. GKE private cluster private endpoint should be enabled - deliberate for remote access

terraform {
required_providers {
google = {
source = "hashicorp/google"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version is typical needed at call sight,
so no need here.

@@ -0,0 +1,117 @@
variable "name" {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be good to add the description and type for all missing ones

Copy link
Contributor

@k4leung4 k4leung4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for reviewing the wiz warnings

@pnasrat pnasrat merged commit 0f2b6fd into chainguard-dev:main Dec 3, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants