github-bots: optionally use a pre-defined service account email #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4leung4
reviewed
Oct 16, 2024
hectorj2f
force-pushed
the
optional_service_account
branch
2 times, most recently
from
7984c25 to
c537c75
Compare
hectorj2f
force-pushed
the
optional_service_account
branch
2 times, most recently
from
a9e9be9 to
799c0a5
Compare
Signed-off-by: hectorj2f <[email protected]>
hectorj2f
force-pushed
the
optional_service_account
branch
from
799c0a5 to
ac755f1
Compare
k4leung4
reviewed
Oct 16, 2024
Signed-off-by: hectorj2f <[email protected]>
|
I tested this patch against an existing bot + authorize service and the SA wasn't changed so AFAICT this won't affect existing deployments that use the default created SA. |
|
@k4leung4 looks ok - you happy to merge? |
imjasonh
reviewed
Oct 17, 2024
Co-authored-by: Jason Hall <[email protected]> Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: hectorj2f <[email protected]>
k4leung4
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing a service account instead of always creating a service account.