github-events: Add multisecret support to trampoline webhook. #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlynch
force-pushed
the
webhook-multisecret
branch
4 times, most recently
from
a141602 to
337e696
Compare
Adds the ability for the trampoline to accept multiple secrets. This tries to retain the existing behavior of the webhook assuming at least one secret by allowing additional secrets to be specified by the same prefix. Additional secrets must be defined and loaded out of band of the service.
wlynch
force-pushed
the
webhook-multisecret
branch
from
337e696 to
d4fe464
Compare
k4leung4
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for the trampoline to accept multiple secrets.
This tries to retain the existing behavior of the webhook assuming at least one secret by allowing additional secrets to be specified by a similar
WEBHOOK_SECRET_prefix.Additional secrets must be defined and loaded out of band of the module.
Also adds testing for the trampoline to verify behavior.
Part of https://github.com/chainguard-dev/internal-dev/issues/1513