networking: Allow configurable netnum offsets. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would try to assign a CIDR block starting from 1. e.g. given cidr = "10.0.0.0/8" and regions = ["a", "b"], you would get: a: "10.1.0.0/16" b: "10.2.0.0/16" Since this always starts at 1, this makes it difficult to be able to select a subnet range. This change adds a field to start subnet numbering at a specific number (starting at 0). e.g. with the previous example and netnum_offset = 10, you would now get: a: "10.10.0.0/16" b: "10.11.0.0/16"
mattmoor
approved these changes
Jan 16, 2024
|
@wlynch you need to update docs for the new field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would try to assign a CIDR block starting from 1.
e.g. given cidr = "10.0.0.0/8" and regions = ["a", "b"], you would get:
a: "10.1.0.0/16"
b: "10.2.0.0/16"
Since this always starts at 1, this makes it difficult to be able to select a subnet range. This change adds a field to start subnet numbering at a specific number (starting at 0).
e.g. with the previous example and netnum_offset = 10, you would now get:
a: "10.10.0.0/16"
b: "10.11.0.0/16"
This is a breaking change if downstream consumers are sensitive to subnet netnum needing to start at 1, but can easily be fixed by adding the netnum_offset. I think we want to do this long term so we don't leave IPs with 0 unassigned.