chore(runs): filter by name instead of id (#1047)

Signed-off-by: Miguel Martinez Trivino <[email protected]>

app/cli/cmd/workflow_workflow_run_list.go

@@ -31,7 +31,7 @@ func newWorkflowWorkflowRunListCmd() *cobra.Command {
 		DefaultLimit: 20,
 	}
 
-	var workflowID, status string
+	var workflowName, status string
 
 	cmd := &cobra.Command{
 		Use:     "list",
@@ -47,7 +47,7 @@ func newWorkflowWorkflowRunListCmd() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			res, err := action.NewWorkflowRunList(actionOpts).Run(
 				&action.WorkflowRunListOpts{
-					WorkflowID: workflowID,
+					WorkflowName: workflowName,
 					Pagination: &action.PaginationOpts{
 						Limit:      paginationOpts.Limit,
 						NextCursor: paginationOpts.NextCursor,
@@ -78,7 +78,7 @@ func newWorkflowWorkflowRunListCmd() *cobra.Command {
 		},
 	}
 
-	cmd.Flags().StringVar(&workflowID, "workflow", "", "workflow ID")
+	cmd.Flags().StringVar(&workflowName, "workflow", "", "workflow name")
 	cmd.Flags().BoolVar(&full, "full", false, "full report")
 	cmd.Flags().StringVar(&status, "status", "", fmt.Sprintf("filter by workflow run status: %v", listAvailableWorkflowStatusFlag()))
 	// Add pagination flags

app/cli/internal/action/workflow_run_list.go

@@ -1,5 +1,5 @@
 //
-// Copyright 2023 The Chainloop Authors.
+// Copyright 2024 The Chainloop Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -63,9 +63,9 @@ func NewWorkflowRunList(cfg *ActionsOpts) *WorkflowRunList {
 }
 
 type WorkflowRunListOpts struct {
-	WorkflowID string
-	Pagination *PaginationOpts
-	Status     string
+	WorkflowName string
+	Pagination   *PaginationOpts
+	Status       string
 }
 type PaginationOpts struct {
 	Limit      int
@@ -75,7 +75,7 @@ type PaginationOpts struct {
 func (action *WorkflowRunList) Run(opts *WorkflowRunListOpts) (*PaginatedWorkflowRunItem, error) {
 	client := pb.NewWorkflowRunServiceClient(action.cfg.CPConnection)
 	req := &pb.WorkflowRunServiceListRequest{
-		WorkflowId: opts.WorkflowID,
+		WorkflowName: opts.WorkflowName,
 		Pagination: &pb.CursorPaginationRequest{
 			Limit:  int32(opts.Pagination.Limit),
 			Cursor: opts.Pagination.NextCursor,

app/controlplane/api/controlplane/v1/api_token.proto

@@ -49,7 +49,7 @@ message APITokenServiceRevokeRequest {
   string name = 1 [(buf.validate.field) = {
     // NOTE: validations can not be shared yet https://github.com/bufbuild/protovalidate/issues/51
     cel: {
-      message: "has an invalid format",
+      message: "must contain only lowercase letters, numbers, and hyphens.",
       expression: "this.matches('^[a-z0-9]([-a-z0-9]*[a-z0-9])?$')",
       id: "name.dns-1123",
     },