Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(verification): option to verify bundle server side in WorkflowRun/View endpoint #1813

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
497 changes: 300 additions & 197 deletions app/controlplane/api/controlplane/v1/workflow_run.pb.go

Large diffs are not rendered by default.

11 changes: 11 additions & 0 deletions app/controlplane/api/controlplane/v1/workflow_run.proto
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ message WorkflowRunServiceViewRequest {
string id = 1 [(buf.validate.field).string.uuid = true];
string digest = 2 [(buf.validate.field).string = {min_len: 1}];
}
// run verification
bool verify = 3;
}

message WorkflowRunServiceViewResponse {
Expand All @@ -223,6 +225,15 @@ message WorkflowRunServiceViewResponse {
message Result {
WorkflowRunItem workflow_run = 1;
AttestationItem attestation = 2;
// It will be nil if the verification is not possible (old or non-keyless attestations)
VerificationResult verification = 3;
}

message VerificationResult {
// if it can be verified this will hold the result of the verification
bool verified = 1;
// why it couldn't be verified, or the failure reason
string failure_reason = 2;
}
}

Expand Down
129 changes: 126 additions & 3 deletions app/controlplane/api/gen/frontend/controlplane/v1/workflow_run.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions app/controlplane/cmd/wire_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading