Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix secret names #1834

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix secret names #1834

merged 2 commits into from
Feb 19, 2025

Conversation

jiparis
Copy link
Member

@jiparis jiparis commented Feb 19, 2025

This PR fixes secret names in deployment to be RFC 1123 compatible.
Refs #1822

445c445
<   generated_jws_hmac_secret: "S1BlTkNvekdxSA=="
---
>   generated_jws_hmac_secret: "MzJRemN5RFlIdg=="
452,453c452,453
<           cert_path: "/sign_secrets_fileCA_0/file_ca.cert"
<           key_path:  "/sign_secrets_fileCA_0/file_ca.key"
---
>           cert_path: "/sign_secrets_fileca_0/file_ca.cert"
>           key_path:  "/sign_secrets_fileca_0/file_ca.key"
477c477
<       generated_jws_hmac_secret: "KPeNCozGqH"
---
>       generated_jws_hmac_secret: "32QzcyDYHv"
502c502
<   name: test-chainloop-controlplane-keyless-fileCA-0
---
>   name: test-chainloop-controlplane-keyless-fileca-0
1614c1614
<         checksum/secret-config: b1dee35ccd0a15f584e519cb49cfd035ff7789f938f0a2b88a79956e364ff0d1
---
>         checksum/secret-config: 12d88e1b082e6ccff0db1e41c8ff0b9e4452eba5113b34a78916171682209fad
1728,1729c1728,1729
<             - name: sign-backend-fileCA-0
<               mountPath: /sign_secrets_fileCA_0
---
>             - name: sign-backend-fileca-0
>               mountPath: /sign_secrets_fileca_0
1744c1744
<         - name: sign-backend-fileCA-0
---
>         - name: sign-backend-fileca-0
1746c1746
<             secretName: test-chainloop-controlplane-keyless-fileCA-0
---
>             secretName: test-chainloop-controlplane-keyless-fileca-0

Signed-off-by: Jose I. Paris <[email protected]>
@jiparis jiparis requested review from migmartri and javirln February 19, 2025 10:08
Signed-off-by: Jose I. Paris <[email protected]>
@jiparis jiparis merged commit 892cf6e into chainloop-dev:main Feb 19, 2025
13 checks passed
@jiparis jiparis deleted the 1822-fix branch February 19, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants