Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Ethereum Consensus API #49

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

erwin-wee
Copy link
Collaborator

Description

  • refactor JsonRPCUser to split the function to HttpUser and JsonRPCUser and add additional functionality to new HttpUser class
  • add EthConsensusUser and EthConsensusMethods classes as base for creating Ethereum Consensus profiles, initially supporting only certain endpoints
  • add EthConsensusTestData and other relevant classes for managing test data for Ethereum Consensus profiles
  • other minor refactoring and code cleanup

Issues Resolved

  • fix issue where Chainbench does not exit cleanly if master runner exits before worker runner is ready
  • fix issue where get_block_worker is started even though there is an exception in fetching test data

- refactor JsonRPCUser to split the function to HttpUser and JsonRPCUser and add additional functionality to new HttpUser class
- add EthConsensusUser and EthConsensusMethods classes as base for creating Ethereum Consensus profiles, initially supporting only certain endpoints
- add EthConsensusTestData and other relevant classes for managing test data for Ethereum Consensus profiles
- fix issue where Chainbench does not exit cleanly if master runner exits before worker runner is ready
- fix issue where get_block_worker is started even though there is an exception in fetching test data
- other minor refactoring and code cleanup
@erwin-wee erwin-wee added bug Something isn't working enhancement New feature or request labels Jan 30, 2024
@erwin-wee erwin-wee self-assigned this Jan 30, 2024
- add ignore_error to suppress mypy error in profile due to false positive on task attribute
- rename classes to follow PascalCase strictly, including acronyms and abbreviations
- rename HttpUser to ChainbenchHttpUser
@erwin-wee erwin-wee merged commit 55e269c into main Jan 31, 2024
5 checks passed
@erwin-wee erwin-wee deleted the feature/eth-consensus branch January 31, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant