Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make machine open state controllable #1203

Merged
merged 20 commits into from
Feb 2, 2024
Merged

Conversation

segunadebayo
Copy link
Member

@segunadebayo segunadebayo commented Jan 30, 2024

Closes #1027
Closes #1204

📝 Description

  • Refactor machine transitions to support controlling open/closed state
  • Improve runtime performance for machines that use "watch"
  • Remove unused event listeners in the machine (we were previously always subscribing to events)
  • Fix issue with delayed after transition

⛳️ Current behavior (updates)

No possible to fully control the machine

🚀 New behavior

Works as expected by carefully adding explicit guards to machine transitions

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 5a52bdf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 68 packages
Name Type
@zag-js/store Patch
@zag-js/core Patch
@zag-js/preact Patch
@zag-js/react Patch
@zag-js/solid Patch
@zag-js/vue Patch
@zag-js/svelte Patch
@zag-js/accordion Patch
@zag-js/avatar Patch
@zag-js/carousel Patch
@zag-js/checkbox Patch
@zag-js/color-picker Patch
@zag-js/combobox Patch
@zag-js/date-picker Patch
@zag-js/dialog Patch
@zag-js/editable Patch
@zag-js/file-upload Patch
@zag-js/hover-card Patch
@zag-js/menu Patch
@zag-js/number-input Patch
@zag-js/pagination Patch
@zag-js/pin-input Patch
@zag-js/popover Patch
@zag-js/presence Patch
@zag-js/progress Patch
@zag-js/radio-group Patch
@zag-js/rating-group Patch
@zag-js/select Patch
@zag-js/slider Patch
@zag-js/splitter Patch
@zag-js/switch Patch
@zag-js/tabs Patch
@zag-js/tags-input Patch
@zag-js/toast Patch
@zag-js/toggle-group Patch
@zag-js/tooltip Patch
@zag-js/tree-view Patch
@zag-js/anatomy-icons Patch
@zag-js/anatomy Patch
@zag-js/docs Patch
@zag-js/types Patch
@zag-js/aria-hidden Patch
@zag-js/auto-resize Patch
@zag-js/collection Patch
@zag-js/color-utils Patch
@zag-js/utils Patch
@zag-js/date-utils Patch
@zag-js/dismissable Patch
@zag-js/dom-event Patch
@zag-js/dom-query Patch
@zag-js/element-rect Patch
@zag-js/element-size Patch
@zag-js/file-utils Patch
@zag-js/focus-scope Patch
@zag-js/focus-visible Patch
@zag-js/form-utils Patch
@zag-js/i18n-utils Patch
@zag-js/interact-outside Patch
@zag-js/live-region Patch
@zag-js/mutation-observer Patch
@zag-js/number-utils Patch
@zag-js/numeric-range Patch
@zag-js/popper Patch
@zag-js/rect-utils Patch
@zag-js/remove-scroll Patch
@zag-js/tabbable Patch
@zag-js/text-selection Patch
@zag-js/visually-hidden Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Feb 2, 2024 6:27pm
zag-solid ✅ Ready (Inspect) Visit Preview Feb 2, 2024 6:27pm
zag-vue ✅ Ready (Inspect) Visit Preview Feb 2, 2024 6:27pm
zag-website ✅ Ready (Inspect) Visit Preview Feb 2, 2024 6:27pm

Copy link
Contributor

Visualize the logic of the machines here 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant