-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(breaking): menu prefer explicit state for option items #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4027d61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Visualize the logic of the machines here 🎊 |
segunadebayo
changed the title
refactor(breaking): menu prefer explicit state for options
refactor(breaking): menu prefer explicit state for option items
Apr 1, 2024
Merged
colinlienard
pushed a commit
to colinlienard/zag
that referenced
this pull request
Jun 18, 2024
…ra-ui#1387) * refactor: menu prefer explicit state for options * fix: types * fix: props * chore: rename types * docs: update typedocs * feat: add highlight change callback * fix: menu props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR refactors the menu machine to use an explicit state for managing option items. This makes the design of the component in Ark UI more flexible and encourages using custom components like
OptionItemGroup
that can encapsulate the state.⛳️ Current behavior (updates)
Option Item State was handled in the menu machine, making it a bit harder to type and prone to name-mismatch errors.
🚀 New behavior
Invert control to the end user.
💣 Is this a breaking change (Yes/No):
Yes
📝 Additional Information