Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with gemma cache on non-fp32 #10

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

chanind
Copy link
Owner

@chanind chanind commented Aug 7, 2024

Currently, gemma2 throws an error when using a dtype other than fp32 with caching. This PR sets the cache dtype to match the model dtype.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (18a7bfc) to head (bd987c7).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   90.62%   90.63%   +0.01%     
==========================================
  Files          20       20              
  Lines        1045     1047       +2     
==========================================
+ Hits          947      949       +2     
  Misses         98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chanind chanind merged commit 52a9fb7 into main Aug 7, 2024
2 checks passed
@chanind chanind deleted the fix-gemma-cache-non-fp32 branch August 7, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants