[Feature] 베지어 스위치 구현 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solchan87
reviewed
Dec 18, 2024
Comment on lines
+15
to
+16
| let label: String | ||
| let isOn: Binding<Bool> |
There was a problem hiding this comment.
Suggested change
| let label: String | |
| let isOn: Binding<Bool> | |
| private let label: String | |
| private let isOn: Binding<Bool> |
| } | ||
|
|
||
| public var body: some View { | ||
| HStack(alignment: .top) { |
There was a problem hiding this comment.
spacing이 빠져있어요. SwiftUI HStack에 spacing 값이 없으면 12정도 값이 들어가더라구요
| HStack(alignment: .top) { | ||
| Text(self.label) | ||
| .applyBezierFontStyle(.caption1Regular, bezierColor: .fgBlackDarkest) | ||
| .frame(minHeight: 40) |
| } | ||
| .animation(.easeInOut(duration: 0.3), value: self.isOn) | ||
| .padding(2) | ||
| .compositingGroup() |
There was a problem hiding this comment.
Suggested change
| .compositingGroup() | |
| .applyDisabledStyle() |
Disable을 고려해서 요 모디파이어를 써주시면 좋을 것 같아요
| import SwiftUI | ||
|
|
||
| public struct BezierSwitchControl: View { | ||
| @Binding public var isOn: Bool |
There was a problem hiding this comment.
Suggested change
| @Binding public var isOn: Bool | |
| @Binding private var isOn: Bool |
|
|
||
| public var body: some View { | ||
| ZStack(alignment: self.alignment) { | ||
| RoundedRectangle(cornerRadius: 100.0, style: .circular) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기본적인 베지어 스위치를 구현합니다