Merge pull request #4 from chanti529/unit-tests

Added unit tests

README.md

@@ -43,11 +43,11 @@ This command gives the info about the size of an Artifact/Folder/Repository in B
         - max-depth: [Default: 4] Max depth to group folders when using folder command type
     - Examples:
     ```
-    $ jfrog repostats download artifact -repos jcenter-remote -path .+.jar
+    $ jfrog repostats download artifact --repos jcenter-remote --path .+.jar
     
-    $ jfrog repostats downlaod folder -repos jcenter-remote -path .+.jar -lastdownloadedto 2020-05-12T15:55:00Z -limit 0 -max-depth 2
+    $ jfrog repostats downlaod folder --repos jcenter-remote --path .+.jar --lastdownloadedto 2020-05-12T15:55:00Z --limit 0 --max-depth 2
     
-    $ jfrog repostats download user -repos jcenter-remote -path .+.jar -lastdownloadedto 2020-05-12T15:55:00Z -limit 0
+    $ jfrog repostats download user --repos jcenter-remote --path .+.jar --lastdownloadedto 2020-05-12T15:55:00Z --limit 0
 
     ```
 
@@ -68,7 +68,7 @@ This command gives the info about the size of an Artifact/Folder/Repository in B
         - max-depth:    [Default: 4] Max depth to group folders when using folder command type
     - Examples:
     ```
-    $ jfrog repostats size artifact -repos maven-local -path .+.jar
+    $ jfrog repostats size artifact --repos maven-local --path .+.jar
 
     ```
 

commands/repostatdownload.go

@@ -5,6 +5,7 @@ import (
 	"github.com/chanti529/repostats/service"
 	"github.com/chanti529/repostats/util"
 	"github.com/cheynewallace/tabby"
+	"github.com/jfrog/jfrog-cli-core/artifactory/utils"
 	"github.com/jfrog/jfrog-cli-core/plugins/components"
 	"strconv"
 	"text/tabwriter"
@@ -75,7 +76,12 @@ func repoStatDownloadCmd(c *components.Context) error {
 	}
 	conf.LastDownloadedTo = lastDownloadedTo
 
-	results, err := service.GetDownloadStat(&conf)
+	servicesManager, err := utils.CreateServiceManager(conf.RtDetails, false)
+	if err != nil {
+		return err
+	}
+
+	results, err := service.GetDownloadStat(&conf, servicesManager)
 	if err != nil {
 		return err
 	}

commands/repostatsize.go

@@ -5,6 +5,7 @@ import (
 	"github.com/chanti529/repostats/service"
 	"github.com/chanti529/repostats/util"
 	"github.com/cheynewallace/tabby"
+	"github.com/jfrog/jfrog-cli-core/artifactory/utils"
 	"github.com/jfrog/jfrog-cli-core/plugins/components"
 	"strconv"
 	"text/tabwriter"
@@ -75,7 +76,12 @@ func repoStatSizeCmd(c *components.Context) error {
 	}
 	conf.ModifiedTo = modifiedTo
 
-	results, err := service.GetSizeStat(&conf)
+	servicesManager, err := utils.CreateServiceManager(conf.RtDetails, false)
+	if err != nil {
+		return err
+	}
+
+	results, err := service.GetSizeStat(&conf, servicesManager)
 	if err != nil {
 		return err
 	}

service/common.go

@@ -126,7 +126,6 @@ func getItemIdentity(item *util.AqlItem, conf *RepoStatConfiguration) (string, e
 		} else {
 			return strings.Join(pathParts[:conf.MaxDepth], "/"), nil
 		}
-		return "", errors.New("Not implemented")
 	case TypeArtifact:
 		return item.GetFullPath(), nil
 	case TypeUser:

service/repostatdownload.go

@@ -4,7 +4,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"github.com/chanti529/repostats/util"
-	"github.com/jfrog/jfrog-cli-core/artifactory/utils"
+	"github.com/jfrog/jfrog-client-go/artifactory"
 	"io/ioutil"
 )
 
@@ -13,12 +13,7 @@ const (
 	aqlDownloadTemplate = `items.find(%s).include("repo", "path", "name", "modified", "modified_by", "stat.downloads", "stat.downloaded")`
 )
 
-func GetDownloadStat(conf *RepoStatConfiguration) ([]StatItem, error) {
-	servicesManager, err := utils.CreateServiceManager(conf.RtDetails, false)
-	if err != nil {
-		return nil, err
-	}
-
+func GetDownloadStat(conf *RepoStatConfiguration, servicesManager artifactory.ArtifactoryServicesManager) ([]StatItem, error) {
 	aqlCriteria := util.AqlSearchCriteria{
 		Repos:              conf.Repos,
 		PropertyFilter:     conf.FilterProperties,