Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivirshup/census builder spatial #1245

Draft
wants to merge 96 commits into
base: main
Choose a base branch
from
Draft

Conversation

ivirshup
Copy link
Collaborator

@ivirshup ivirshup commented Jul 12, 2024

x* #1092

To install from this branch

gh pr checkout 1245
pip install -e tools/cellxgene_census_builder

TODO

  • Update source datasets links to ones which use schema v5.1.0
  • Update builder
    • Don't include normalized layer
    • Figure out what set of genes to use
    • populate spatial collection
      • Add a scene per ingested dataset
    • Add obs_scene table
    • Add var_scene table
    • Allow writing duplicates to loc
    • Filter out objects with .uns["spatial"]["is_single"]==False (current filtering code seems to rely only on columns in obs)
  • Tests
    • Check equivalence of written data to input anndata
      • loc
      • images

prathapsridharan and others added 30 commits June 7, 2024 15:59
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 79.50530% with 58 lines in your changes missing coverage. Please review.

Project coverage is 91.00%. Comparing base (1f55385) to head (a8a2898).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../cellxgene_census_builder/build_soma/build_soma.py 41.30% 54 Missing ⚠️
...ne_census_builder/build_soma/experiment_builder.py 93.33% 2 Missing ⚠️
...cellxgene_census_builder/build_soma/consolidate.py 75.00% 1 Missing ⚠️
...ols/cellxgene_census_builder/tests/test_spatial.py 99.13% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
- Coverage   91.35%   91.00%   -0.35%     
==========================================
  Files          82       83       +1     
  Lines        6480     6706     +226     
==========================================
+ Hits         5920     6103     +183     
- Misses        560      603      +43     
Flag Coverage Δ
unittests 91.00% <79.50%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Deglobalize obs column selection

* Added a slide-seq dataset to builds in test suite

* Add spatial manifest with both slide-seq and visium

* Address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft Census schema for support of Visium and Spatial data
3 participants