Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add file size #418

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: Add file size #418

merged 2 commits into from
Jan 17, 2025

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Jan 17, 2025

Relates to Capture file size in the database

Description

  • Update db schema
  • Update import scripts
  • Update Integer to BigInteger
  • Add pagination
  • Update tests
  • Run import scripts for all datasets
  • Update client
  • Update documentation

@kaloster kaloster requested a review from jgadling January 17, 2025 22:45
@kaloster kaloster added the stack label Jan 17, 2025
@@ -95,7 +95,7 @@ def get_s3_client(
"s3",
region_name=settings.AWS_REGION,
endpoint_url=settings.BOTO_ENDPOINT_URL,
config=Config(signature_version="s3v4"),
config=Config(signature_version="s3v4", retries={"max_attempts": 10, "mode": "adaptive"}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to avoid rate limit errors experienced in the first run:

botocore.exceptions.ClientError: An error occurred (SlowDown) when calling the GetObject operation (reached max retries: 4): Please reduce your request rate.

Copy link
Contributor

@jgadling jgadling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaloster kaloster force-pushed the kaloster/filesize-float branch from 29c36bd to c0f1a23 Compare January 17, 2025 22:50
@kaloster kaloster removed the stack label Jan 17, 2025
@kaloster kaloster merged commit 3760c15 into main Jan 17, 2025
7 of 8 checks passed
@kaloster kaloster deleted the kaloster/filesize-float branch January 17, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants