-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CZID-8624] Enforce and automate changelog updates #305
Open
morsecodist
wants to merge
6
commits into
main
Choose a base branch
from
tmorse-changelog-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4800fc0
enforce changelog
morsecodist e238e8d
conflict
morsecodist 4759a09
fix release message
morsecodist a61e1c0
tested script
morsecodist 591e121
docs
morsecodist 269998f
Merge branch 'main' into tmorse-changelog-update
rzlim08 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,15 +32,23 @@ fi | |
if [[ $WORKFLOW_NAME == amr ]]; then | ||
TAG="amr-v1.3.0" | ||
vincent-czi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
fi | ||
TAG_MSG=$(mktemp) | ||
|
||
if [[ $( git branch --show-current) != "main" ]]; then | ||
COMMIT=$(git rev-parse --short HEAD) | ||
TAG=$TAG"-$COMMIT" | ||
echo "# Changes for ${TAG} ($(date +%Y-%m-%d))" > $TAG_MSG | ||
echo "$RELEASE_NOTES" >> $TAG_MSG | ||
else | ||
git config --local user.email "[email protected]" | ||
git config --local user.name "GitHub Action" | ||
sed -i "s/^### $WORKFLOW_NAME-unreleased/### $TAG/g" "CHANGELOG.md" | ||
git add "CHANGELOG.md" | ||
git commit -m "Update changelog for version $TAG" | ||
git push origin main | ||
sed -n "/^### $TAG/,/^### /p" "CHANGELOG.md" | sed '1d;$d' >> $TAG_MSG | ||
fi | ||
|
||
TAG_MSG=$(mktemp) | ||
echo "# Changes for ${TAG} ($(date +%Y-%m-%d))" > $TAG_MSG | ||
echo "$RELEASE_NOTES" >> $TAG_MSG | ||
git log --pretty=format:%s ${OLD_TAG}..HEAD >> $TAG_MSG || true | ||
if ! git config --get user.name ; then | ||
git config user.name "CZ ID release action triggered by ${GITHUB_ACTOR:-$(whoami)}" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit confused by this phrasing until you explained it on the team meeting. Maybe expand this a bit to say:
"A text message summarizing the changes in this release. Unused for standard major/minor/patch releases, but used for branch releases."
I'm not sure that's great, but just something clarifying that it doesn't have an expected use in "normal" release flows.