Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Conditionally create grant #647

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: Conditionally create grant #647

merged 3 commits into from
Oct 1, 2024

Conversation

alldoami
Copy link
Contributor

@alldoami alldoami commented Oct 1, 2024 •
edited
Loading

Summary

Fix reference to volume name, not bucket name.

Test Plan

Say unittests, or list out steps to verify changes.

References

(Optional) Additional links to provide more context.

@alldoami alldoami marked this pull request as ready for review October 1, 2024 18:08
@alldoami alldoami requested a review from a team as a code owner October 1, 2024 18:08
@alldoami alldoami requested a review from psnonis October 1, 2024 18:08
@alldoami alldoami enabled auto-merge (squash) October 1, 2024 18:09
@alldoami alldoami merged commit f068b40 into main Oct 1, 2024
108 checks passed
@alldoami alldoami deleted the CDI-3377-conditional-create-grant branch October 1, 2024 18:14
@czi-github-helper czi-github-helper bot mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjb007 jjb007 jjb007 approved these changes

@psnonis psnonis Awaiting requested review from psnonis psnonis is a code owner automatically assigned from chanzuckerberg/czi-shared-infra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alldoami @jjb007