[breaking] make aws provider optional #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it optional to specify an aws provider. Only planning on supporting this for config v2 but it might work in v1 for some cases. The only breaking change is that we now require an aws account id for the global component, where before we would silently ignore the fact that it was missing.
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 79.07% 79.12% +0.04%
==========================================
Files 15 16 +1
Lines 1214 1236 +22
==========================================
+ Hits 960 978 +18
- Misses 147 150 +3
- Partials 107 108 +1
Continue to review full report at Codecov.
|
ryanking
commented
May 15, 2019
| @@ -218,9 +219,9 @@ func TestCreateFileNonExistentDirectory(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestApplySmokeTest(t *testing.T) { | |||
| a := assert.New(t) | |||
| r := require.New(t) | |||
There was a problem hiding this comment.
require fails fast, while assert keeps going
ryanking
commented
May 15, 2019
| @@ -231,6 +232,7 @@ func TestApplySmokeTest(t *testing.T) { | |||
| "aws_profile_provider": "prof", | |||
| "aws_profile_backend": "prof", | |||
| "aws_provider_version": "0.12.0", | |||
| "account_id": 789, | |||
There was a problem hiding this comment.
You now need to specify an account_id for global
ryanking
commented
May 15, 2019
| @@ -0,0 +1,188 @@ | |||
| package v2 | |||
There was a problem hiding this comment.
this is mostly just moved code from v2/validations.go
ryanking
commented
May 15, 2019
|
|
||
| // ResolveAWSProvider will return an AWSProvder iff one of the required fields is set somewhere in the set of Common | ||
| // config objects passed in. Otherwise it will return nil. | ||
| func ResolveAWSProvider(commons ...Common) *AWSProvider { |
ryanking
commented
May 15, 2019
| @@ -10,14 +10,14 @@ | |||
| } | |||
|
|
|||
| # Aliased Providers (for doing things in every region). | |||
| {{ $out := . }} | |||
| {{ $outter := . }} | |||
There was a problem hiding this comment.
trying to make it clearer that we are capturing the outer scope
ryanking
commented
May 15, 2019
| ../../../terraform.d |
There was a problem hiding this comment.
this was a bug, fixed now. unfortunately our tests don't catch this because we don't do any assertions on links
edulop91
reviewed
May 16, 2019
edulop91
reviewed
May 16, 2019
edulop91
reviewed
May 16, 2019
edulop91
reviewed
May 16, 2019
edulop91
reviewed
May 16, 2019
edulop91
approved these changes
May 16, 2019
palasha
pushed a commit
to palasha/fogg
that referenced
this pull request
Apr 7, 2020
[breaking] make aws provider optional### Summary This change makes it optional to specify an aws provider. Only planning on supporting this for config v2 but it might accidentally work in v1. The only breaking change is that we now require an aws account id for the global component, where before we would silently ignore the fact that it was missing. I consider this a bug / oversight so fixing it here. ### Test Plan This diff adds a number of tests, especially golden file tests. None of the existing golden files had to be changed. ### References *
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change makes it optional to specify an aws provider. Only planning on supporting this for config
v2 but it might accidentally work in v1.
The only breaking change is that we now require an aws account id for the global component, where before we would silently ignore the fact that it was missing. I consider this a bug / oversight so fixing it here.
Test Plan
This diff adds a number of tests, especially golden file tests. None of the existing golden files had to be changed.
References