Fetch route supports search params #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneymbell
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Made one small suggestion in the reducer to check that their value of galagoPathogen is one we recognize and provide a slightly different default. Otherwise this looks great / don't need to see this again, thank you so much! I'll get mrca squared away shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts an approach in place for handling chanzuckerberg#186 .
Only actually handles pathogen right now. This is mostly about putting in a process for building search (AKA query) params out over time. Right now there is a stub for pulling in
galagoMrca/mrcavalue, but nothing downstream in the reducer actually uses that param value. Location stuff is untouched with this, but I think it should be pretty easy to build on this to add params as needed. Just need to add in the param toALL_GALAGO_PARAMS, then insert handling logic in theFETCH_TREE_DATA_SUCCEEDEDreducer func.