Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS compatibility improvements #329

Merged
merged 7 commits into from
Feb 2, 2020
Merged

macOS compatibility improvements #329

merged 7 commits into from
Feb 2, 2020

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Feb 2, 2020

  • default --runtime-cpu-max and --runtime-memory-max to the resources available in Docker for Mac's virtual machine, rather than the entire host
  • miniwdl run_self_test failure displays hint on overriding TMPDIR (docker folder permissions on Mac #324)
  • documentation

There are still some problems, particularly with the full test suite, tracking in #145

@coveralls
Copy link

coveralls commented Feb 2, 2020

Pull Request Test Coverage Report for Build 1501

  • 37 of 39 (94.87%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 96.81%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/_util.py 33 35 94.29%
Totals Coverage Status
Change from base Build 1492: 0.006%
Covered Lines: 4855
Relevant Lines: 5015

💛 - Coveralls

@mlin mlin merged commit f5a97f5 into master Feb 2, 2020
@mlin mlin deleted the mlin-macos branch February 2, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants