Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(navigationjumpto): refactor the onChange prop #906

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(navigationjumpto): refactor the onChange prop #906

wants to merge 3 commits into from

Conversation

masoudmanson
Copy link
Contributor

@masoudmanson masoudmanson commented Nov 25, 2024 •
edited
Loading

Summary

NavigationJumpTo
Github issue: #905

Addressing this issue: https://czi-sci.slack.com/archives/C032S43KKFV/p1732305246765639

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Nov 25, 2024 that may be closed by this pull request
Refactor the onChange Prop in the NavigationJumpTo Component #905
Open
@masoudmanson masoudmanson self-assigned this Nov 25, 2024
@masoudmanson masoudmanson added Work in Progress This PR is a work in progress P0 Feature Request labels Nov 25, 2024
@masoudmanson masoudmanson added Ready for review This PR is ready for review and removed Work in Progress This PR is a work in progress labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tihuan tihuan Awaiting requested review from tihuan

At least 1 approving review is required to merge this pull request.

Assignees

@masoudmanson masoudmanson

Labels
Feature Request P0 Ready for review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the onChange Prop in the NavigationJumpTo Component
1 participant
@masoudmanson