Enum docs patch #26394
Enum docs patch #26394
Conversation
astatide
force-pushed
the
astatide/enum_docs_patch
branch
from
31a6c91 to
616216e
Compare
|
FYI, the Chapel team generally suggests tagging a team member when opening a PR to be sure someone looks at it. |
| writeln("there's too much fraternizing with the enemy."); } | ||
| when statesman.Plato do | ||
| { write("I only wish that wisdom were the kind of thing that flowed..."); | ||
| writeln("... from the vessel that was full to the one that was empty."); } |
There was a problem hiding this comment.
Thank you for your patch! I think you might need to update the expected output of the test, as well. See like 657 specifically. Please feel free to ping me when the PR is ready for another look.
There was a problem hiding this comment.
Ah, I had totally missed that! I've gone ahead and updated it.
There was a problem hiding this comment.
Additionally, I was double checking the attribution of the quote, and it looks like it ought to be attributed to Socrates? This Wikiquote page suggests that Plato wrote down the saying in the PR's diff as having been said by Socrates.
There was a problem hiding this comment.
Ah, damn! I can't quite remember the source (I found a good site resource for it but the attribution format was a little strange), but it looks like you're right. Lemme try and find another one since Socrates is already in there.
There was a problem hiding this comment.
Oh, wait; it's Aristotle that's already in here, not Socrates. Should I just update it to Socrates, then?
There was a problem hiding this comment.
Changed! Also, excellent catch! Thank you for double checking!
There was a problem hiding this comment.
Thank you! Using Socrates seems good to me. I am going (and have been, really) on break for the holidays, but your PR will be near the top of my queue in the new year.
There was a problem hiding this comment.
Ah! No no, take your time! It's a small change, obviously. You should be enjoying your holiday, not participating in PRs! 😂
Thank you either way, though!
astatide
force-pushed
the
astatide/enum_docs_patch
branch
from
f6e3b60 to
cd896de
Compare
Signed-off-by: Audrey MP <[email protected]>
Signed-off-by: Audrey MP <[email protected]>
…etter Signed-off-by: Audrey MP <[email protected]>
error. Signed-off-by: Audrey MP <[email protected]>
astatide
force-pushed
the
astatide/enum_docs_patch
branch
from
4bddbc7 to
f2b36a6
Compare
|
All tests pass! Merging this now. |
A quick PR to replace Kissinger with Plato.